-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add German UI translation #50929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add German UI translation #50929
Conversation
|
cc @TJaniF if you want to check any translations |
|
Let's rebase after the changes in #50930 |
af7217e to
9dd9b9f
Compare
TJaniF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sehr cool! :)
Just a few small suggestions.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functionally, can't vouch for the translation accuracy unfortunately.
1 minor nit.
+1 for not translating core concepts and keeping their english version.
9dd9b9f to
02db93c
Compare
Thanks @TJaniF for the review! Looking forward for the |
* Add German UI translation * Add German UI translation, small nit * Review fedback * Rebase translation and some rework * Second review round
* Add German UI translation * Add German UI translation, small nit * Review fedback * Rebase translation and some rework * Second review round
After #50626 this adds German as language. Would also offer to take the CODEOWNER-ship to maintain German translation.
(Updated from commit 02db93c):
