Skip to content

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented May 21, 2025

After #50626 this adds German as language. Would also offer to take the CODEOWNER-ship to maintain German translation.

(Updated from commit 02db93c):
image

@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. labels May 21, 2025
@bbovenzi
Copy link
Contributor

cc @TJaniF if you want to check any translations

@TJaniF
Copy link
Contributor

TJaniF commented May 22, 2025

cc @TJaniF if you want to check any translations

Thank you for the ping! :)
@jscheffl This looks great I can't wait to show it in a webinar 😄 . I had a handful nitpicks and suggestions, feel free to ignore them :)

@bbovenzi
Copy link
Contributor

Let's rebase after the changes in #50930

@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
@jscheffl jscheffl force-pushed the feature/add-german-ui-translation branch from af7217e to 9dd9b9f Compare May 22, 2025 19:24
@jscheffl jscheffl requested review from TJaniF and bbovenzi May 22, 2025 19:25
Copy link
Contributor

@TJaniF TJaniF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr cool! :)

Just a few small suggestions.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally, can't vouch for the translation accuracy unfortunately.

1 minor nit.

+1 for not translating core concepts and keeping their english version.

@jscheffl jscheffl force-pushed the feature/add-german-ui-translation branch from 9dd9b9f to 02db93c Compare May 23, 2025 19:30
@jscheffl
Copy link
Contributor Author

Sehr cool! :)

Just a few small suggestions.

Thanks @TJaniF for the review! Looking forward for the de_CH translation! Grüezi :-D

@jscheffl jscheffl merged commit 7453b18 into apache:main May 23, 2025
51 checks passed
dadonnelly316 pushed a commit to dadonnelly316/airflow that referenced this pull request May 26, 2025
* Add German UI translation

* Add German UI translation, small nit

* Review fedback

* Rebase translation and some rework

* Second review round
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Add German UI translation

* Add German UI translation, small nit

* Review fedback

* Rebase translation and some rework

* Second review round
@jscheffl jscheffl deleted the feature/add-german-ui-translation branch October 5, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants